Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pyjsontool which uses the json format to download files. #123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jwhite66
Copy link
Contributor

Also add a message when a file is invalid.

@JamieSinn
Copy link
Owner

I'd prefer not to create fractional support here - given the new binary will be multiplatform.

@jwhite66
Copy link
Contributor Author

Sure, I understand your reasoning and this is your call. I'll just note that I have a strong preference for a CLI tool, and a simple one in Python is very compelling to me. What's important is that we all rally behind a single data file.

@JamieSinn
Copy link
Owner

Can you rebase this into a new folder to consolidate the Python stuff?

@jwhite66
Copy link
Contributor Author

I've rebased this branch. It sounds like you'd like to move the python scripts into a separate directory. My inclination would be to create two new subdirectories; an archive and a scripts directory. I would move all of the .CSV files into the archive, along with the pyusbtool.py script; I would rename the pyjsontool.py back to pyusbtool.py and put it in the scripts folder, perhaps with a README. Would you like me to do that?

@JamieSinn
Copy link
Owner

I'll move the old csv files after the 2025 season - as the previous v1 tool will break by doing that and I still want to maintain compat for at least this year - as it looks for the specific root folder CSV - but otherwise that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants